Remove most warnings and deprecations from tests - #667
Open
GKFX wants to merge 1 commit into
Open
Conversation
GKFX
marked this pull request as draft
October 8, 2020 14:24
GKFX
marked this pull request as ready for review
October 8, 2020 14:24
This commit is dependant on FriendsOfSymfony#663 or FriendsOfSymfony#666 to upgrade the PHPUnit dependency to ^8. It brings the tests to a passing state by removing all deprecation warnings that are within this project's control.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is dependant on #663 or #666 to upgrade the PHPUnit dependency to ^8. It brings the tests to a passing state by removing all deprecation warnings that are within this project's control, and configuring PHPUnit to be aware that the remaining 6 warnings are not fixable.
See passing CI result for this commit put on top of #663 at https://travis-ci.com/github/GKFX/FOSOAuthServerBundle/builds/188814729.