Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: connection modal improvements #277

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
Draft

feat: connection modal improvements #277

wants to merge 22 commits into from

Conversation

arthurgeron
Copy link
Contributor

@arthurgeron arthurgeron commented Sep 23, 2024 •
edited
Loading

closes: #265

Package Changes

React

Fuel UI Provider refactored:

  • Dialog State added
  • Install, Connecting, Installed and Error dialog screens
  • Separate connection and retry

Fuel Wallet

  • JSON RPC client is restarted befor pinging if the extension is not detected as installed

All

  • Updated Fuel SDK to PR-3201, which introduces external property on connectors

Evidence

CleanShot.2024-09-23.at.10.24.23.mp4

@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuel-connectors ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 1:27pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

Coverage Report for Fuel Wallet (./packages/fuel-wallet)

Status Category Percentage Covered / Total
🔵 Lines 59.74% 141 / 236
🔵 Statements 59.74% 141 / 236
🔵 Functions 56.66% 17 / 30
🔵 Branches 86.95% 20 / 23
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/fuel-wallet/src/FuelWalletConnector.ts 57.58% 86.36% 56.66% 57.58% 69-76, 80-85, 87, 91, 95-96, 99-100, 103-110, 113-114, 117-124, 127-131, 134-143, 151-158, 162-167, 229-230, 236-253, 293-300
Generated in workflow #701

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

Coverage Report for Fuel Development Wallet (./packages/fuel-development-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 16 / 16
🔵 Statements 100% 16 / 16
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #701

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

Coverage Report for Fuelet Wallet (./packages/fuelet-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 19 / 19
🔵 Statements 100% 19 / 19
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #701

@luizstacio luizstacio changed the base branch from main to ls/feat/add-request-validation September 23, 2024 04:44
@arthurgeron arthurgeron force-pushed the ag/feat/connection-modal branch from eaacd77 to 0807768 Compare September 23, 2024 12:19
helciofranco
helciofranco previously approved these changes Sep 23, 2024
View reviewed changes
@arthurgeron arthurgeron force-pushed the ag/feat/connection-modal branch from 35c7218 to b0caf8a Compare September 23, 2024 13:26
luizstacio
luizstacio requested changes Sep 23, 2024
View reviewed changes
Copy link
Member

@luizstacio luizstacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold this in favor of: #275

@luizstacio luizstacio marked this pull request as draft September 23, 2024 14:03
Base automatically changed from ls/feat/add-request-validation to main September 23, 2024 14:39
@arthurgeron arthurgeron dismissed helciofranco’s stale review September 23, 2024 14:39

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizstacio luizstacio luizstacio requested changes

@helciofranco helciofranco helciofranco left review comments

@pedronauck pedronauck Awaiting requested review from pedronauck pedronauck is a code owner

@LuizAsFight LuizAsFight Awaiting requested review from LuizAsFight LuizAsFight is a code owner

@rodrigobranas rodrigobranas Awaiting requested review from rodrigobranas rodrigobranas is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arthurgeron @luizstacio @helciofranco