Fixed the error during dry run #2365
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
reviewed
Oct 16, 2024
Comment on lines
-362
to
-363
| block.entity.header().time(); | ||
|
|
AurelienFT
previously approved these changes
Oct 16, 2024
acerone85
previously approved these changes
Oct 16, 2024
xgreenx
dismissed stale reviews from acerone85 and AurelienFT
The base branch was changed.
AurelienFT
previously approved these changes
Oct 17, 2024
AurelienFT
approved these changes
Oct 31, 2024
MitchTurner
reviewed
Oct 31, 2024
| @@ -649,27 +649,33 @@ mod dry_run { | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
| async fn dry_run__errors_early_if_height_is_lower_than_chain_tip() { | |||
There was a problem hiding this comment.
I did a quick scan but couldn't see a test for this on the produce or produce_predefined. Maybe I missed it. Do you think we need that coverage?
There was a problem hiding this comment.
We have test case for BlockHeightShouldBeHigherThanPrevious error.
But after introduction of the state rewind feature, I don't think that BlockHeightShouldBeHigherThanPrevious error makes a lot of sense. Basically importer already is responsible and upgradable executor do this kind of check inside, some maybe we can just remove it from the block producer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of race condition it was possible that dry run will fail. I moved the check to production, where we really need to require this behavior. But in the case of the dry run we only care about previous block existence.
Checklist
Before requesting review