Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change derivative to educe #2659

Merged
merged 22 commits into from
Feb 20, 2025
Merged

Change derivative to educe #2659

merged 22 commits into from
Feb 20, 2025
+33 −23

Conversation

AurelienFT
Copy link
Contributor

Linked Issues/PRs

#2426

Description

Derivative is unmaintained and educe is a close drop-in. A similar PR has been already merged in the VM : FuelLabs/fuel-vm#876

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

rymnc
rymnc previously approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be interesting to see change in wasm bytecode size after this

xgreenx
xgreenx previously approved these changes Feb 10, 2025
View reviewed changes
@AurelienFT AurelienFT dismissed stale reviews from xgreenx and rymnc via 6c8a727 February 10, 2025 09:34
xgreenx
xgreenx previously approved these changes Feb 11, 2025
View reviewed changes
@AurelienFT AurelienFT changed the title Update derive_more and change derivative to educe Change derivative to educe Feb 12, 2025
@AurelienFT AurelienFT requested review from xgreenx and rymnc February 12, 2025 00:21
xgreenx
xgreenx previously approved these changes Feb 12, 2025
View reviewed changes
@AurelienFT AurelienFT merged commit 8f447b5 into master Feb 20, 2025
34 checks passed
@AurelienFT AurelienFT deleted the remove_derivative branch February 20, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xgreenx xgreenx xgreenx approved these changes

@netrome netrome netrome approved these changes

@Dentosal Dentosal Awaiting requested review from Dentosal Dentosal is a code owner

@MitchTurner MitchTurner Awaiting requested review from MitchTurner MitchTurner is a code owner

@acerone85 acerone85 Awaiting requested review from acerone85 acerone85 is a code owner

@rymnc rymnc Awaiting requested review from rymnc rymnc is a code owner

@rafal-ch rafal-ch Awaiting requested review from rafal-ch rafal-ch is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AurelienFT @xgreenx @netrome @rymnc @rafal-ch