Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the P2P message limits #2705

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Increase the P2P message limits #2705

merged 3 commits into from
Feb 12, 2025

Conversation

AurelienFT
Copy link
Contributor

Description

Increase the P2P limits to allow to sync correctly. Previously the default number of blocks in a batch could have been higher than the default maximum size. Now the default values for each parameters are aligned.

(We discovered it with big blocks on various networks)

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

@AurelienFT AurelienFT requested a review from a team February 12, 2025 00:07
@AurelienFT AurelienFT requested a review from a team February 12, 2025 00:11
Copy link
Member

@rymnc rymnc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to check if the deployment uses the defaults or overrides too

@rymnc rymnc merged commit a80e427 into master Feb 12, 2025
33 checks passed
@rymnc rymnc deleted the adjust_p2p_limits branch February 12, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants