Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reviewers in update README action #2706

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

AurelienFT
Copy link
Contributor

@AurelienFT AurelienFT commented Feb 12, 2025

Description

Currently, all the action readme update jobs are failing because the group "FuelLabs/client" can't be seen by the Action and so it can't assign it as reviewer. This PR comes back to what we do with cargo update, we just let our repository rules determine the reviewers.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

@AurelienFT AurelienFT requested a review from a team February 12, 2025 09:31
@AurelienFT AurelienFT self-assigned this Feb 12, 2025
@AurelienFT AurelienFT added the no changelog Skip the CI check of the changelog modification label Feb 12, 2025
@AurelienFT
Copy link
Contributor Author

Job now works tested on chain-configuration : FuelLabs/chain-configuration#20

@AurelienFT AurelienFT enabled auto-merge (squash) February 12, 2025 11:11
@AurelienFT AurelienFT mentioned this pull request Feb 12, 2025
@AurelienFT AurelienFT merged commit 0c87663 into master Feb 12, 2025
45 of 46 checks passed
@AurelienFT AurelienFT deleted the fix_readme_action branch February 12, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants