Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust-analyzer): nits that are showing up as errors #2735

Merged
merged 1 commit into from
Feb 20, 2025
Merged

fix(rust-analyzer): nits that are showing up as errors #2735

merged 1 commit into from
Feb 20, 2025
+5 −5

Conversation

rymnc
Copy link
Member

@rymnc rymnc commented Feb 20, 2025

Linked Issues/PRs

  • none

Description

rust-analyzer failing on my machine because of these errors

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

@rymnc rymnc added the no changelog Skip the CI check of the changelog modification label Feb 20, 2025
@rymnc rymnc self-assigned this Feb 20, 2025
@rymnc rymnc marked this pull request as ready for review February 20, 2025 16:24
@rymnc rymnc merged commit 2471df6 into master Feb 20, 2025
37 of 48 checks passed
@rymnc rymnc deleted the fix/rust-analyzer branch February 20, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MitchTurner MitchTurner MitchTurner approved these changes

@AurelienFT AurelienFT AurelienFT approved these changes

@xgreenx xgreenx Awaiting requested review from xgreenx xgreenx is a code owner

@Dentosal Dentosal Awaiting requested review from Dentosal Dentosal is a code owner

@netrome netrome Awaiting requested review from netrome netrome is a code owner

@acerone85 acerone85 Awaiting requested review from acerone85 acerone85 is a code owner

Assignees

@rymnc rymnc

Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rymnc @MitchTurner @AurelienFT