Dedicated threads for the block importer #2750
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed cloning of teh block and utilized the feature of rayon runtime with scoped parallel jobs execution. Moved code to catch `InvalidDatabaseStateAfterExecution` to the right place. Removed requirements from the database to be modifiable. Fixed the not working `async` part of the block importer. Before importing of the block were blocking the tokio task and `await` never was reached.
xgreenx
requested review from
Dentosal,
MitchTurner,
netrome,
acerone85,
rafal-ch,
rymnc and
AurelienFT
as code owners
AurelienFT
approved these changes
Feb 22, 2025
| @@ -167,6 +167,8 @@ async fn _gas_price_updater__can_recover_on_startup_when_gas_price_db_is_behind( | |||
| Some(BlockHeight::new(height)) | |||
| ); | |||
|
|
|||
| tokio::time::sleep(std::time::Duration::from_millis(20)).await; | |||
There was a problem hiding this comment.
Do you want to sneak this change or it's leftover ?
| @@ -50,7 +50,7 @@ async fn poa_instant_trigger_is_produces_instantly() { | |||
| ) | |||
| .add_fee_input() | |||
| .finalize_as_transaction(); | |||
| let _tx_id = client.submit(&tx).await.unwrap(); | |||
| let _tx_id = client.submit_and_await_commit(&tx).await.unwrap(); | |||
There was a problem hiding this comment.
Do you want to sneak this change or it's leftover ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed cloning of the block and utilized the feature of rayon runtime with scoped parallel jobs execution.
Moved code to catch
InvalidDatabaseStateAfterExecutionto the right place.Removed requirements from the database to be modifiable.
Fixed the not working
asyncpart of the block importer. Before importing of the block were blocking the tokio task andawaitnever was reached.