Introduce build_deploy_transaction function on Contract #1306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1305
This PR doesn't exactly solve the issue, but adds a possibility to get the tx id from the built transaction. I didn't want to change the
deploy
method signature, cause it'll trigger changes in the whole project.So, the proposed solution to get the tx id is:
However, I'm not sure if that's correct, cause in that flow the deploy transaction will be built twice (by calling
build_deploy_transaction
and thendeploy
), so potentially these two transactions might differ. Let me know what you think