Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make OrdEq trait public #6723

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Make OrdEq trait public #6723

wants to merge 5 commits into from
+104 −103

Conversation

bitzoic
Copy link
Member

@bitzoic bitzoic commented Nov 14, 2024 •
edited
Loading

Description

An internal contributor noted that the OrdEq trait was private. Although it could be used if implemented on the impl statement directly, this has been made public to allow for importing through the use statement.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@bitzoic bitzoic added the lib: std Standard library label Nov 14, 2024
@bitzoic bitzoic self-assigned this Nov 14, 2024
@bitzoic bitzoic requested review from a team as code owners November 14, 2024 04:09
@bitzoic bitzoic requested a review from a team as a code owner November 14, 2024 04:37
alfiedotwtf
alfiedotwtf previously approved these changes Nov 14, 2024
View reviewed changes
alfiedotwtf
alfiedotwtf reviewed Nov 14, 2024
View reviewed changes
forc-plugins/forc-doc/src/tests/expects/impl_trait/mod.rs
@@ -43,124 +43,125 @@ fn test_impl_traits_default() {
doc_dir_name,
project_name,
vec![
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't help for this PR, but for later PRs, should these be sorted so that diffs can be easier on the eyes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K1-R1 K1-R1 K1-R1 approved these changes

@tritao tritao tritao approved these changes

@xunilrj xunilrj xunilrj approved these changes

@alfiedotwtf alfiedotwtf alfiedotwtf approved these changes

Assignees

@bitzoic bitzoic

Labels
lib: std Standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bitzoic @alfiedotwtf @xunilrj @tritao @K1-R1 @JoshuaBatty