-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate prelude imports from star imports #6971
Open
jjcnn
wants to merge
17
commits into
master
Choose a base branch
from
jjcnn/prelude_overridden_by_star_import
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #6971 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6119 .
Blocked by #6729, sort of. The failing CI checks are due to the
sway-lsp
tests being pinned tostd
v0.48.1, which is from before reexports were introduced. This means that prelude items are not public in those tests, causing asserts in this PR to fail. #6729 will update thesway-lsp
tests to use the latest version ofstd
, at which point the CI checks of this PR ought to pass.Currently, items implicitly imported from the standard library preludes reside in the same namespace as star imports from non-prelude sources. This means that if a star import imports a name that clashes with a name from a prelude, then using that name in the importing module causes an error.
This PR separates the prelude imports into a different namespace, and allows star imports to shadow prelude imports.
Checklist
Breaking*
orNew Feature
labels where relevant.