Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move access to externals to Namespace #6999

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jjcnn
Copy link
Contributor

@jjcnn jjcnn commented Mar 6, 2025

Description

Fixes #6846 .

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@jjcnn jjcnn self-assigned this Mar 6, 2025
@jjcnn jjcnn added the team:compiler Compiler Team label Mar 6, 2025
@jjcnn jjcnn temporarily deployed to fuel-sway-bot March 6, 2025 14:35 — with GitHub Actions Inactive
Copy link

codspeed-hq bot commented Mar 6, 2025

CodSpeed Performance Report

Merging #6999 will not alter performance

Comparing jjcnn/externals_to_namespace (37e9b54) with master (d22ff45)

Summary

✅ 22 untouched benchmarks

@jjcnn jjcnn temporarily deployed to fuel-sway-bot March 7, 2025 20:50 — with GitHub Actions Inactive
@jjcnn jjcnn force-pushed the jjcnn/externals_to_namespace branch from 06fbfba to 25b6b12 Compare March 7, 2025 21:04
@jjcnn jjcnn temporarily deployed to fuel-sway-bot March 7, 2025 21:05 — with GitHub Actions Inactive
@jjcnn jjcnn force-pushed the jjcnn/externals_to_namespace branch from 25b6b12 to 0bcb817 Compare March 7, 2025 21:38
@jjcnn jjcnn temporarily deployed to fuel-sway-bot March 7, 2025 21:38 — with GitHub Actions Inactive
@jjcnn jjcnn temporarily deployed to fuel-sway-bot March 7, 2025 23:29 — with GitHub Actions Inactive
@jjcnn jjcnn temporarily deployed to fuel-sway-bot March 7, 2025 23:49 — with GitHub Actions Inactive
@jjcnn jjcnn temporarily deployed to fuel-sway-bot March 11, 2025 15:11 — with GitHub Actions Inactive
@jjcnn jjcnn force-pushed the jjcnn/externals_to_namespace branch from a3ad7a2 to e2c5eff Compare March 11, 2025 15:32
@jjcnn jjcnn temporarily deployed to fuel-sway-bot March 11, 2025 15:33 — with GitHub Actions Inactive
@jjcnn jjcnn temporarily deployed to fuel-sway-bot March 11, 2025 15:58 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:compiler Compiler Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move code depending on external_packages from Root to Namespace
1 participant