Skip to content

Conversation

@Starexify
Copy link

@Starexify Starexify commented Oct 1, 2025

Linked Issues

Fixes #5468

Description

The voice waveforms were misaligned with the health icons because they used preset positions, causing them to appear off-center.
This PR fixes that by centering them on the health icons, correcting the alignment for any resolution.

It also aligns the icons x position to now be based on the width of the icon instead of preset, which might bring visual issues for larger icons.

Screenshots/Videos

Before (0.7.5):

image

Wide Screen (0.7.5):

image

This PR (After):

image

Wide Screen (After)

image

@github-actions github-actions bot added status: pending triage Awaiting review. size: small A small pull request with 10 or fewer changes. pr: haxe PR modifies game code. and removed size: small A small pull request with 10 or fewer changes. labels Oct 1, 2025
@Starexify Starexify changed the title Fixed waveforms x positions to align with the center of health icons. [BUGFIX] Fixed waveforms x positions to align with the center of health icons. Oct 1, 2025
@Starexify Starexify changed the title [BUGFIX] Fixed waveforms x positions to align with the center of health icons. [BUGFIX/Chart Editor] Fixed waveforms x positions to align with the center of health icons. Oct 1, 2025
@Hundrec
Copy link
Member

Hundrec commented Oct 1, 2025

Oh nice!

@Hundrec Hundrec added type: minor bug Involves a minor bug or issue. topic: chart editor Related to the operation of the Chart Editor. size: small A small pull request with 10 or fewer changes. labels Oct 1, 2025
@trayfellow
Copy link

True...

@AbnormalPoof AbnormalPoof force-pushed the center-waveforms branch 2 times, most recently from c3863f8 to 9e850fa Compare October 14, 2025 01:11
@Hundrec Hundrec added status: reviewing internally Under consideration and testing. and removed status: pending triage Awaiting review. labels Oct 14, 2025
@Hundrec Hundrec changed the title [BUGFIX/Chart Editor] Fixed waveforms x positions to align with the center of health icons. [BUGFIX] Align x positions of Chart Editor waveforms to the center of the health icons Oct 14, 2025
Copy link
Member

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed the waveforms render incorrectly if you press the Chart Editor key in either Freeplay or PlayState.
Not sure what's different about those, but please fix this

image

@Hundrec Hundrec added status: needs revision Cannot be approved because it is awaiting some work by the contributor. and removed status: reviewing internally Under consideration and testing. labels Oct 14, 2025
@Starexify
Copy link
Author

Just noticed the waveforms render incorrectly if you press the Chart Editor key in either Freeplay or PlayState.
Not sure what's different about those, but please fix this

image

I wonder if this happens in dev 🤔
I'll check, but I didnt think that since I never used the keys myself 😅

@github-actions github-actions bot added size: medium A medium pull request with 100 or fewer changes. and removed size: small A small pull request with 10 or fewer changes. labels Oct 14, 2025
@Starexify Starexify requested a review from Hundrec October 14, 2025 16:34
Copy link
Member

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing still happens

@Starexify
Copy link
Author

Same thing still happens

But i tested and it didnt, how is it possible 😭

@Hundrec Hundrec added status: reviewing internally Under consideration and testing. and removed status: needs revision Cannot be approved because it is awaiting some work by the contributor. labels Oct 15, 2025
@Hundrec Hundrec self-requested a review October 15, 2025 16:00
@Hundrec
Copy link
Member

Hundrec commented Oct 15, 2025

Alright, you fixed it!
One more thing I'd like is for Boyfriend's icon to be nudged slightly to the left.
Before this PR, the waveforms were equally distanced from the chart grid, but now the player's is a little further away.
Can you move him (or his waveform) just a bit to the left?

@Starexify Starexify changed the title [BUGFIX] Align x positions of Chart Editor waveforms to the center of the health icons [BUGFIX/Chart Editor] Center waveforms on health icons and adjust icon X-offsets Oct 15, 2025
Copy link
Member

@Hundrec Hundrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this is in working condition. Some odd aspect ratios make the icons and waveforms act funny, but that's more of a dynamic resolution problem than anything else.

Thanks for making the icons and waveforms adaptive!
I'll merge this once I confirm it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: reviewing internally Under consideration and testing. topic: chart editor Related to the operation of the Chart Editor. type: minor bug Involves a minor bug or issue.

Development

Successfully merging this pull request may close these issues.

Bug Report: Chart Editor Waveforms don't display properly on certain resolutions

3 participants