-
Notifications
You must be signed in to change notification settings - Fork 2.4k
[BUGFIX/Chart Editor] Center waveforms on health icons and adjust icon X-offsets #6193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Oh nice! |
|
True... |
c3863f8 to
9e850fa
Compare
9e850fa to
c8612ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
74499ed to
a9c2f20
Compare
a9c2f20 to
9d4cacb
Compare
9d4cacb to
857a3d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing still happens
But i tested and it didnt, how is it possible 😭 |
e6d6788 to
607abc1
Compare
|
Alright, you fixed it! |
219eb87 to
c351150
Compare
c351150 to
e9b315e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this is in working condition. Some odd aspect ratios make the icons and waveforms act funny, but that's more of a dynamic resolution problem than anything else.
Thanks for making the icons and waveforms adaptive!
I'll merge this once I confirm it works.

Linked Issues
Fixes #5468
Description
The voice waveforms were misaligned with the health icons because they used preset positions, causing them to appear off-center.
This PR fixes that by centering them on the health icons, correcting the alignment for any resolution.
It also aligns the icons x position to now be based on the width of the icon instead of preset, which might bring visual issues for larger icons.
Screenshots/Videos
Before (0.7.5):
Wide Screen (0.7.5):
This PR (After):
Wide Screen (After)