Skip to content

[BUGFIX] Various Freeplay difficulty dot and navigation fixes #6205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

[BUGFIX] Various Freeplay difficulty dot and navigation fixes #6205

wants to merge 4 commits into from
+9 −5

Conversation

@ComedyLost
Copy link

Linked Issues

Fixes #3912
Fixes #4918

Description

This PR changes/fixes:

  • How the difficulty sprites and difficulty dots are added to be based on SongRegistry's listAllDifficulties function instead of the DEFAULT_DIFFICULTY_LIST_FULL constants variable, allowing mods with extra difficulties to show properly in the freeplay menu
  • The order in which all song difficulties are grabbed from SongRegistry's listAllDifficulties function to have all base game difficulties start first in the array
  • Stops the Freeplay menu from regaining control while the Alt Instrumental Menu is open

Screenshots/Videos

BEFORE (Freeplay difficulty order + Custom difficulty sprite/difficulty dots:

2025-10-03.01-57-05.mp4

AFTER (Freeplay difficulty order + Custom difficulty sprite/difficulty dots:

2025-10-03.01-58-17.mp4

Alt Instrumental Menu fix:

2025-10-03.02-08-29.mp4

@github-actions github-actions bot added size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. pr: haxe PR modifies game code. and removed status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. labels Oct 3, 2025
@Hundrec Hundrec added type: minor bug Involves a minor bug or issue. status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. labels Oct 4, 2025
TechnikTil
TechnikTil approved these changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@TechnikTil TechnikTil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please merge this immediately.

@MAZ12211
Copy link

MAZ12211 commented Oct 6, 2025

The difficulty sorting issue bugged me out the most
Claps 👏

@Hundrec Hundrec changed the title [BUG FIX / ENHANCEMENT] Freeplay State - Fixed custom difficulty sprites and extra difficulty dots not appearing, difficulty order changing, and stops inputs while in the alt instrumental menu [BUGFIX] Various Freeplay difficulty dot and navigation fixes Oct 6, 2025
This was linked to issues Oct 6, 2025
Bug Report: Alt inst selector doesn't lock Freeplay navigation when opened directly after returning from Character Select #4918
Open
Bug Report: Custom difficulty sprites don't show up in freeplay #3912
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TechnikTil TechnikTil TechnikTil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue.

Milestone

No milestone

4 participants

@ComedyLost @MAZ12211 @TechnikTil @Hundrec