[BUGFIX] Fix health bar resetting incorrectly after restarting a song. #6217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pr: haxe
4 tasks
Member
|
Very nice, love tiny detail fixes |
…enu. Also health values during onSongRetry are now be the correct values instead of the old ones
Hundrec
requested changes
Oct 14, 2025
Member
Hundrec
left a comment
Hundrec
left a comment
There was a problem hiding this comment.
This PR does fix the restarting position, but no longer lerps.
Can you restore that behavior?
Hundrec
added
status: needs revision
Author
Lerps? You mean it should lerp from the old value to current value instead of directly going to the new value? Because tbf didnt notice it and it isnt like that in the src where I modified, so thats interestingly odd 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues
Fixes #6009
Description
This PR fixes the health bar value being incorrect after resetting a song.
Additionally, the health reset logic is now into it's own function
resetHealth()for convenience.For modding convenience, this also changes the order of the health bar reset so that
onSongRetryreceives the updated values after resetting.Screenshots/Videos
0.7.5:
0.7.5.mp4
This PR:
PR.mp4
As seen in this image, the original values when loading a song are indeed 1-1-0
Here is how the differences look like visually:
(Start showing how it looks like when starting the song)