Skip to content

[OPTIMIZATION] Remove unused Chart Editor Context Menu code #6283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[OPTIMIZATION] Remove unused Chart Editor Context Menu code #6283

wants to merge 1 commit into from

Conversation

@anysad
Copy link
Contributor

@anysad anysad commented Oct 14, 2025 •
edited
Loading

Linked Issues

None

Description

  • The game previously was registering an event listening for whenever the user would click their mouse button, which was most likely used to display the default context menu meant for testing that is not left unused.

Funkin/source/funkin/ui/debug/charting/ChartEditorState.hx

Line 3284 in e62c5a2

// this.openDefaultContextMenu(xPos, yPos);

Yet, the game does not unregisted the mouse event, and to be fair, there is no point for it to be registered in the first place.

@github-actions github-actions bot added status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. and removed size: medium A medium pull request with 100 or fewer changes. labels Oct 14, 2025
@Hundrec Hundrec added topic: chart editor Related to the operation of the Chart Editor. type: optimization Involves a performance issue or a bug which causes lag. size: medium A medium pull request with 100 or fewer changes. labels Oct 15, 2025
@Hundrec Hundrec changed the title [CHORE] Remove unused Chart Editor Context Menu code [OPTIMIZATION] Remove unused Chart Editor Context Menu code Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. topic: chart editor Related to the operation of the Chart Editor. type: optimization Involves a performance issue or a bug which causes lag.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anysad @Hundrec