Skip to content

[ENHANCEMENT/TWEAK] Add offset var to note in NoteStyle.hx #6326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[ENHANCEMENT/TWEAK] Add offset var to note in NoteStyle.hx #6326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions source/funkin/play/notes/notestyle/NoteStyle.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ class NoteStyle implements IRegistryEntry<NoteStyleData>

target.antialiasing = !(_data.assets?.note?.isPixel ?? false);

var noteOffsets:Array<Float> = getNoteOffsets();
target.offset.set(noteOffsets[0], noteOffsets[1]);

// Apply the animations.
buildNoteAnimations(target);

Expand Down Expand Up @@ -180,6 +183,11 @@ class NoteStyle implements IRegistryEntry<NoteStyleData>
return _data.assets?.note?.scale ?? fallback?.getNoteScale() ?? 1.0;
}

public function getNoteOffsets():Array<Float>
{
return _data?.assets?.note?.offsets ?? fallback?.getNoteOffsets() ?? [0.0, 0.0];
}

function fetchNoteAnimationData(dir:NoteDirection):Null<AnimationData>
{
var result:Null<AnimationData> = switch (dir)
Expand Down