Skip to content

Fix wrong checks for NaN throughout the code #6344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix wrong checks for NaN throughout the code #6344

wants to merge 1 commit into from
+3 −3

Conversation

@NotHyper-474
Copy link
Contributor

@NotHyper-474 NotHyper-474 commented Oct 24, 2025 •
edited
Loading

Description

Fixes wrong checks for NaN, the Math.isNaN function should be used instead of comparing the values because it's always gonna be false

https://try.haxe.org/#6ea88699
^ You can see how Math.isNaN returns the correct result here

@github-actions github-actions bot added status: pending triage Awaiting review. pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. labels Oct 24, 2025
@AbnormalPoof AbnormalPoof added the type: minor bug Involves a minor bug or issue. label Oct 25, 2025
@FuroYT
Copy link

FuroYT commented Oct 25, 2025

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@moxie-coder moxie-coder moxie-coder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

pr: haxe PR modifies game code. size: small A small pull request with 10 or fewer changes. status: pending triage Awaiting review. type: minor bug Involves a minor bug or issue.

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NotHyper-474 @FuroYT @moxie-coder @AbnormalPoof