Replace "zoom" with FlxSprite.scale property for SustainTrail.hx #6367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pr: haxe
T5mpler
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally because of how sprites are drawn with FlxStrip, properties that would be available in FlxSprite like "scale" and "angle" aren't able to be used and do nothing.
This PR adds the ability to be able to use FlxSprite.scale instead of the zoom property to be able to mess with the scaling of a sustain note.
By default, scale.y being 1 represents the default length of the sustain note being controlled (so for example, if you set scale.y to 0.5 then the sustain note will be 50% of it's actual length but will still work), meanwhile scaling x controls the actual width of the sustain note instead of the original zoom property.
Seeing as the zoom property is a private variable in the original class and is only used to initialize the sprite, I don't think this is really a breaking change, but idk.
If you have any suggestions for what to add to this feel free to let me know, as well as if this PR has any issues.
Demonstration here:
