[OPTIMIZATION] Run OGG files through OptiVorbis #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
|
Thanks for making this! I think before we can accept one of these, we need to fix a bunch of issues with a lot of the audio tracks. |
Hundrec
added
status: pending triage
|
Alright, sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Saw this PR a while ago that had plans to be merged but was ultimately abandoned.
Here im doing the same thing as the old one, running all Vorbis files through OptiVorbis to optimize a bit of filesize with lossless quality. Which saves around 30mb of file size, not bad considering all original quality is preserved.
Hoping that now with the new Github team it'll be much smoother trying to merge a sizeable PR like this.
As a little note, aside from this PR, I've also noticed that the current vorbis audio files fluctuate a lot in quality. Some songs can take up to 4mb of size, while their erect counterparts only take 1mb. Could be worth something to look into.