Softcode Winter Horrorland Cutscene #275
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
github-actions
bot
added
the
size: medium
Hundrec
added
status: pending triage
|
Thanks for bringing this change back to the front. Do you believe your script here would be better than #63? |
|
Yes since it's the most up-to-date implementation from the source code and works the exact same as when it was hardcoded |
|
That's good. But, needs to some clean-up. Like replacing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the previously hardcoded winter horrorland cutscene into a scripted song file.
Requires FunkinCrew/Funkin#6189 to be merged in order to work properly