[ENHANCEMENT] Better function argument validation.#383
Open
Starexify wants to merge 2 commits intoFunkinCrew:experimentalfrom
Open
[ENHANCEMENT] Better function argument validation.#383Starexify wants to merge 2 commits intoFunkinCrew:experimentalfrom
Starexify wants to merge 2 commits intoFunkinCrew:experimentalfrom
Conversation
Co-authored-by: NotHyper-474 <40342021+nothyper-474@users.noreply.github.com>
…nd reword `EInvalidArgCount` for better clarity.
Starexify
force-pushed
the
fix-arg-overflow
branch
from
c43c407 to
1dccecb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issues
Description
This PR fixes the argument validation crashing when native functions call scripts with less arguments than function parameters.
Also add a new error
EExceedArgsCountthat is thrown when passing more arguments than the function parameters have.And finally changed the
EInvalidArgCounterror message from:Invalid number of given arguments. Got x, required y for functionto
Provided arguments are fewer than the required function parameters. Got x, required y for function