This repository was archived by the owner on Mar 25, 2024. It is now read-only.
Implement P2P protocol for device control #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsleepr
reviewed
May 31, 2020
eufy_security/types.py
Outdated
| ] | ||
|
|
||
| def is_station(self): | ||
| return self in [DeviceType.STATION, DeviceType.FLOODLIGHT] |
Contributor
There was a problem hiding this comment.
Suggested change
| return self in [DeviceType.STATION, DeviceType.FLOODLIGHT] | |
| return self in [DeviceType.STATION, DeviceType.FLOODLIGHT, DeviceType.DOORBELL] |
Contributor
|
Looks promising. Wasn't able to connect to the my doorbell with that yet though. Will dig deeper. |
| @@ -0,0 +1,69 @@ | |||
| import asyncio | |||
|
|
|||
There was a problem hiding this comment.
I think we need to import logging here and add something like:
_LOGGER: logging.Logger = logging.getLogger(__name__)
Contributor
|
I think I figured out why it's not working with the doorbell: When you do discovery, STUN servers actually send your (client's) host/port to the doorbell. Since you open a new connection (with a new port) to connect to every new host, the doorbell gets the port different from the one you're using to connect to it. You should open only one connection and use it to communicate with everything. |
Author
|
Ah, that does makes sense, but it seems like @joepadmiraal's attempt wasn't even getting that far -- it didn't seem like there was even a valid response from the discovery servers. |
Contributor
|
Could be |
|
I'm replying here instead of in the issue to concentrate our findings. And sometimes I get this output. In this case it will hang (waited for 2 minutes) instead of stop the program. |
Author
|
Sweet! So I think you're getting around the NAT issues that @nonsleepr might be hitting since you’re accessing your device over LAN, but it's at least looking more promising. It seems like it was able to communicate with the doorbell and is stuck because it didn't receive a packet that I expected it should based on my own testing. Can you try the latest commit and share another tcpdump if it still hangs? |
|
Seems better now: Do you still want the a new tcpdump? |
Author
|
Nope, from the output it looks like it ran successfully. It should have momentarily turned on the on screen watermark (the Eufy logo in the top left) of the live video feed for a couple seconds and then turned it off. Can you confirm that actually happens? Also, to clarify, do you have a wired or wireless doorbell? |
|
The watermark is successfully added and removed in the video. |
Contributor
I'm trying to connect over internet and not getting the response from the doorbell (I explained the reason above). (my own implementation using single connection works, BTW, I'll see if I can release that). |
|
@keshavdv and @nonsleepr u guys gave up on this ? Or can I still check out this branch and give it a shot ? |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what the PR does:
This is an initial attempt at implementing the peer to peer protocol in Python that is heavily based on https://github.com/fbertone/lib32100 combined with Eufy-specific elements. I only have a single "standalone" device (floodlight) so I can't test certain features that I know won't work just yet. Apart from that, it does seem to at least work (see added example for usage) but I imagine there needs to be a discussion on the best API to expose from within this library to make it more friendly for other applications so there still aren't any unit tests.
Does this fix a specific issue?
Nope, new feature.
Checklist:
README.mdwith any new documentation.AUTHORS.md.