Restore default GNSS band and frequency mappings#7
Open
JianquanLu wants to merge 1 commit into
Open
Conversation
Use the existing per-system defaults when band settings are omitted and terminate the QZSS switch cases explicitly. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<band>is omittedProblem
t_gsetgnss::_band()throws immediately when no band list is configured. This makes the default mappings directly below the exception unreachable, even though defaults are already defined for GPS, GLONASS, Galileo, BDS, and QZSS.As a result, configurations that rely on the default behavior fail during initialization with:
Fix
Remove the unconditional exception so the existing constellation-specific defaults are used, and add the missing
breakstatements to the QZSS cases in both_band()and_freq().Verification
Tested from commit
3b4f383a2724c1b0c4748cb0b0cb80e0bc430740on Windows with MSVC Release:<band>/<freq>settings omitted completes successfully (exit 0)exit 0)git diff --checkpassesNo observation data, generated products, binaries, or local paths are included in this PR.
🤖 Generated with Claude Code