Handle missing satellite objects and extend BDS satellite identifiers#8
Open
JianquanLu wants to merge 2 commits into
Open
Handle missing satellite objects and extend BDS satellite identifiers#8JianquanLu wants to merge 2 commits into
JianquanLu wants to merge 2 commits into
Conversation
Skip observations whose satellite object is unavailable before querying antenna PCV data, avoiding a null pointer dereference. Co-Authored-By: Claude <noreply@anthropic.com>
Allocate satellite objects for BDS PRNs C47 through C58 and C61 through C63 so valid observations such as C56 can use their ANTEX records. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The static BDS satellite list omits C47-C58 and C61-C63. When an observation contains one of these satellites, such as C56,
t_gallobj::obj()returns an emptyshared_ptreven when the ANTEX file contains a calibration record for that satellite.great::t_gpvtflt::_preprocess()then dereferences it unconditionally:This causes a segmentation fault/access violation at the first epoch containing C56.
Fix
_preprocess()so a future unknown or unavailable satellite object produces a warning and is removed from that epoch instead of crashing the process.Verification
Tested from commit
3b4f383a2724c1b0c4748cb0b0cb80e0bc430740using an ANTEX file containing a C56 record:exit 0git diff --checkpassNo observation data, generated products, binaries, or local paths are included in this PR.
🤖 Generated with Claude Code