Skip to content

Handle Docker multi-protocol port bindings when creating challenge containers #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 5 commits into
base: develop
Choose a base branch
from
+26 −4
Open

Handle Docker multi-protocol port bindings when creating challenge containers #576

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
60c3ecf
Initial plan
Copilot Apr 27, 2026
fa1fc6f
fix: handle multi-protocol docker port bindings
Copilot Apr 27, 2026
2b0d4b3
test: align docker port binding regression coverage
Copilot Apr 27, 2026
59533b5
refactor: use list patterns for port binding selection
Copilot Apr 27, 2026
9ac70ee
fix: address docker binding review feedback
Copilot Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 26 additions & 4 deletions src/GZCTF/Services/Container/Manager/DockerManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,11 +226,9 @@ await _client.Containers.RemoveContainerAsync(parameters.Name,
if (!_meta.ExposePort)
return container;

var portString = config.ExposedPort.ToString();
var bindings = info.NetworkSettings.Ports.Where(kv => kv.Key.StartsWith(portString)).Select(kv => kv.Value)
.SingleOrDefault();
var bindings = GetPublishedPortBindings(info.NetworkSettings.Ports, config.ExposedPort);

if (bindings is not { Count: > 0 })
if (bindings is [])
{
_logger.SystemLog(
StaticLocalizer[
Expand Down Expand Up @@ -258,6 +256,30 @@ await _client.Containers.RemoveContainerAsync(parameters.Name,
return container;
}

internal static IList<PortBinding> GetPublishedPortBindings(
IDictionary<string, IList<PortBinding>>? ports, int exposedPort)
{
if (ports is not { Count: > 0 })
return [];

var port = exposedPort.ToString();
var portPrefix = $"{port}/";
var matchedPorts = ports
.Where(kv => kv.Value is { Count: > 0 }
&& kv.Key.StartsWith(portPrefix, StringComparison.Ordinal))
.ToArray();

return matchedPorts switch
{
[] => [],
[{ Value: var bindings }] => bindings,
_ => matchedPorts.FirstOrDefault(kv =>
kv.Key.EndsWith("/tcp", StringComparison.OrdinalIgnoreCase))
.Value
?? matchedPorts[0].Value
};
}

private CreateContainerParameters GetCreateContainerParameters(GZCTF.Models.Internal.ContainerConfig config) =>
new()
{
Expand Down
Loading