Skip to content

fix[#1]: none of the feeds vaildate#3

Merged
GabsEdits merged 6 commits intomainfrom
fix/#1
Apr 5, 2026
Merged

fix[#1]: none of the feeds vaildate#3
GabsEdits merged 6 commits intomainfrom
fix/#1

Conversation

@GabsEdits
Copy link
Copy Markdown
Owner

Closes #1

@GabsEdits GabsEdits requested a review from Copilot June 5, 2025 14:58
@GabsEdits GabsEdits self-assigned this Jun 5, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses feed validation issues by updating both RSS and JSON feed formats.

  • Removed the extraneous element from the RSS feed output.
  • Removed the "updated" property from JSON feed tests and corrected the date formatting call.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
test.ts Adjusted tests to expect feeds without the element and without the "updated" property.
src/rss.ts Removed the redundant element in the RSS feed generation.
src/json.ts Fixed the date_published field to correctly invoke toUTCString(), ensuring proper timestamp.
Comments suppressed due to low confidence (1)

src/rss.ts:51

  • Consider adding an inline comment explaining why the element has been removed to ensure future maintainers understand this change is intended to comply with feed validation standards.
    <author>${emailPart}(${escapedName})</author>\n

@GabsEdits GabsEdits marked this pull request as ready for review April 5, 2026 19:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

test.ts:211

  • RssFeed.build() no longer emits a channel-level <author> element (removed in src/rss.ts), but the RSS snapshot comparison will still expect one because the expected template includes <author>…</author> inside <channel>. This will fail the snapshot test; update the expected RSS snapshot to match the new output (remove the <author> line) or revert the generator change if <author> must remain.
      </channel>
    </rss>
`.replace(/\n\s+/g, "\n").trim();


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

GabsEdits and others added 2 commits April 5, 2026 22:09
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/GabsEdits/feed/sessions/ebb47305-a1e4-4248-a25a-41a78784b5d5

Co-authored-by: GabsEdits <110247388+GabsEdits@users.noreply.github.com>
@GabsEdits GabsEdits merged commit ee7a675 into main Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

None of the feeds validate right now

3 participants