Test free-threaded Python with pytest-run-parallel #2649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continues the work started in: * Gallopsled#2627
pytest --doctest-modules --iterations=8 --parallel-threads=auto
Updated Python version matrix for CI workflow to use fewer versions during debugging.
Added pytest and pytest-run-parallel to documentation dependencies and adjusted pytest command.
Increased timeout for pytest-run-parallel and added multiple test commands.
Removed pytest-run-parallel from documentation dependencies installation and added pytest-timeout. Updated pytest commands to include timeout and adjusted installation of pytest-run-parallel.
cclauss
changed the title
Member
|
pwnlib isn't fully thread-safe so this might reveal some areas that need work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues the work started in:
To be confident about free-threaded compatibility, it is recommended to test with
pytest-run-parallel.Something like:
%
uvx --with=pytest-run-parallel pytest --iterations=8 --parallel-threads=autoPwntools Pull Request
Thanks for contributing to Pwntools! Take a moment to look at
CONTRIBUTING.mdto make sure you're familiar with Pwntools development.Please provide a high-level explanation of what this pull request is for.
Testing
Pull Requests that introduce new code should try to add doctests for that code. See
TESTING.mdfor more information.Target Branch
Depending on what the PR is for, it needs to target a different branch.
You can always change the branch after you create the PR if it's against the wrong branch.
devdevstablestablebranchbetabetabranch, but notstabledevChangelog
After creating your Pull Request, please add and push a commit that updates the changelog for the appropriate branch.
You can look at the existing changelog for examples of how to do this.