Skip to content

Conversation

@2over12
Copy link
Collaborator

@2over12 2over12 commented Sep 18, 2025

Im not sure we want to do this and if we do we should delay the solver

@langston-barrett
Copy link
Collaborator

This is reasonable, it will make @fresh-bytes work in more situations and it's only expensive in the case where it's really needed. However, I'd prefer to use the concretization functionality that I'm planning to add to What4 rather than that from Macaw: there's no reason for that code to live in Macaw, and I'd like to deprecate it. GaloisInc/what4#264

LCS.RegValue' sym (LCT.BVType w) ->
LCS.OverrideSim p sym ext r args ret (LCS.RegValue sym (LCT.VectorType (LCT.BVType 8)))
freshBytes name0 bv0 =
freshBytes bak name0 bv0 =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to pass bak around everywhere, you can use ovrWithBackend.

Copy link
Collaborator Author

@2over12 2over12 Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think you can since you need onlinesolver for the concretization stuff right? the backend wont have the correct constraints

@langston-barrett langston-barrett changed the title Concretize fresh bytes Concretize the argument to @fresh-bytes Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants