Metallurgy adjust gold max damage + remove redundancy #1167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misode
approved these changes
Oct 13, 2025
| data modify storage gm4_audere_shamir:temp/player/tool SelectedItem set from entity @s SelectedItem | ||
| execute store result score $tool_current_damage gm4_ml_data run data get storage gm4_audere_shamir:temp/player/tool SelectedItem.components."minecraft:damage" | ||
| execute store result score $tool_max_damage gm4_ml_data run data get storage gm4_audere_shamir:temp/player/tool SelectedItem.components."minecraft:custom_data".gm4_audere_shamir.max_durability | ||
| execute store result score $tool_max_damage gm4_ml_data run data get storage gm4_audere_shamir:temp/player/tool SelectedItem.components."minecraft:custom_data".MaxDurability |
Member
There was a problem hiding this comment.
It seemed like this was not a backwards compatible change, but I realize that moneo is always installed, and thus the MaxDurability tag should be present on all tools. (I think?)
The comment in moneo's store_maximum function could probably make it clear that it runs for all shamirs.
Related, I think right now infinitas' make_unstackable runs for every shamir, not only for infinitas, which maybe isn't a problem, but still weird.
runcows
added a commit
to runcows/GM4_Datapacks
that referenced
this pull request
Oct 26, 2025
runcows
added a commit
to runcows/GM4_Datapacks
that referenced
this pull request
Oct 31, 2025
misode
pushed a commit
that referenced
this pull request
Nov 3, 2025
* Remove deprecated `CanDuplicate` nbt from Gemini Shamir breed allay - This data field was removed in 1.21.5 * Add copper torch to Crossbow Cartridges * Metallurgy Copper Tools (not RP) * Replace `#gm4:boots` with `#minecraft:foot_armor` * Update `shamir_model_template.py` with copper * Adjust gold max damage + remove redundancy (#1167) * Update overlays with gold arborenda PR changes * Swap most overlays to `backport_81` - Disassemblers was left as `since_88` as the contents are generated - Standard Crafting was left as `since_88` because inverting it is not easy without errors in prior versions * More resource pack stuff? * Update `modeldata_registry` with copper Metallurgy Expansions - Update `modeldata_registry` with copper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gold tools had the wrong max damage (33 instead of 32) causing an off by 1 error
Both Audere Shamir and Moneo Shamir set a max durability custom data on tools, this redundancy has been eliminated, favoring just the function from Moneo Shamir.
However, there is potentially an open question of if we should move this function into the
gm4_metallurgynamespace, since it's common functionality. That has not been done here yet, but can be.