removed the inner span that hid the sorting triggers#32
Open
sliceofcake wants to merge 1 commit intoGamesDoneQuick:masterfrom
Open
removed the inner span that hid the sorting triggers#32sliceofcake wants to merge 1 commit intoGamesDoneQuick:masterfrom
sliceofcake wants to merge 1 commit intoGamesDoneQuick:masterfrom
Conversation
Removed the inner span that was made to hide the sorting trigger elements. It looks like queueindex.css has .asc and .dsc classes that ought to be here, but for now, it's good enough to just show "AscDsc" despite it not looking the best for the time being. I saw no nearby comments explaining why this was done. It was clearly done deliberately in a hasty attempt to amend something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the inner span that was made to hide the sorting trigger
elements. It looks like queueindex.css has .asc and .dsc classes that
ought to be here, but for now, it's good enough to just show "AscDsc"
despite it not looking the best for the time being.
I saw no nearby comments explaining why this was done. It was clearly
done deliberately in a hasty attempt to amend something.