Skip to content

ci: auto-tag releases + stamp version from tag (CashPilot-Desktop-rrb)#98

Merged
GeiserX merged 1 commit into
mainfrom
fix/loop-rrb-auto-tag
Jul 18, 2026
Merged

ci: auto-tag releases + stamp version from tag (CashPilot-Desktop-rrb)#98
GeiserX merged 1 commit into
mainfrom
fix/loop-rrb-auto-tag

Conversation

@GeiserX

@GeiserX GeiserX commented Jul 18, 2026

Copy link
Copy Markdown
Owner

Problem (PR #96 devops review)

Desktop releases required a human to push a v* tag, so they lagged — PRs #94/#95 sat merged-but-unreleased for 2+ days — and wails.json productVersion silently drifted (stayed 0.9.0 through the whole v0.10.0 release; nothing read or validated it).

Fix

auto-tag.yml (new): on push to main, compute the next semver from conventional-commit markers since the last tag (feat:→minor, type!:/BREAKING CHANGE→major, else patch — identical to the web repo), push the tag, then call desktop-release.yml as a reusable workflow to build/publish.

The reusable call is deliberate: a tag pushed with the default GITHUB_TOKEN does not trigger another workflow (GitHub loop-prevention), so relying on desktop-release.yml's own push: tags trigger here would silently never build. This mirrors how the web repo calls build.yml. A human pushing a tag by hand still triggers desktop-release.yml directly, unchanged.

desktop-release.yml: gains workflow_call (with a version input) and a Set release version step that stamps wails.json's productVersion and both package.json versions from the tag via jq before building — so every artifact matches its tag and the drift can no longer happen. The tag is now the single source of truth.

Verification

  • actionlint clean on both workflows.
  • jq injection produces valid JSON with the right version (tested locally on the real files).
  • No Go code reads wails.json/productVersion, so the build-time stamp can't break go test.
  • Path filters exclude .github/**, so a workflow-only change never cuts a release; the next code merge to main will release the accumulated work.

Closes bead CashPilot-Desktop-rrb.

…ilot-Desktop-rrb)

Desktop releases required a human to push a v* tag and lagged (merged work sat
unreleased for days), and wails.json productVersion silently drifted because
nothing read or synced it.

Add auto-tag.yml: on push to main it computes the next semver from conventional
commits since the last tag (same logic as the web repo), pushes the tag, then
CALLS desktop-release.yml as a reusable workflow to build/publish. The reusable
call is deliberate — a tag pushed with GITHUB_TOKEN does not trigger another
workflow, so desktop-release.yml's own tag trigger would silently never fire.
A human-pushed tag still triggers it directly, unchanged.

desktop-release.yml now stamps productVersion (and both package.json versions)
from the tag at build time via jq, so every artifact matches its tag — the drift
can no longer happen. Verified with actionlint; jq injection and version-compute
logic checked locally.
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@GeiserX, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 29 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: eb6fd821-90b4-4b39-9101-f723639ddaa4

📥 Commits

Reviewing files that changed from the base of the PR and between ab8b25c and 92f40d2.

📒 Files selected for processing (2)
  • .github/workflows/auto-tag.yml
  • .github/workflows/desktop-release.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/loop-rrb-auto-tag

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@GeiserX

GeiserX commented Jul 18, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@GeiserX
GeiserX merged commit 854084b into main Jul 18, 2026
6 checks passed
@GeiserX
GeiserX deleted the fix/loop-rrb-auto-tag branch July 18, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant