Skip to content

refactor(ui): extract shared action-button icon constants (CashPilot-cyc)#124

Merged
GeiserX merged 1 commit into
mainfrom
fix/loop-cyc-svg-icons
Jul 18, 2026
Merged

refactor(ui): extract shared action-button icon constants (CashPilot-cyc)#124
GeiserX merged 1 commit into
mainfrom
fix/loop-cyc-svg-icons

Conversation

@GeiserX

@GeiserX GeiserX commented Jul 18, 2026

Copy link
Copy Markdown
Owner

First safe step of the cyc builder componentization, now that browser verification is unblocked.

What

renderServiceRow duplicated the restart/stop/logs SVG icons verbatim — 6 copies (3 icons × single-instance row + per-node sub-row). Extracted to ICON_RESTART/ICON_STOP/ICON_LOGS module consts.

Why it's provably safe

Per the migration review, "byte-identical" is only guaranteed at the DOM level. Verified three ways:

  1. DOM golden-master — rendered the multi-instance row + expanded per-node sub-rows (via a mocked running service in a headless Chromium harness), dumped the table innerHTML before and after: byte-identical (10346 bytes, zero diff).
  2. node --check clean; the CP export surface is unchanged.
  3. Playwright harness: the row + all action buttons (stop/restart/logs ×2, credential, expand) render and the expand toggle works, with 0 console/page errors.

Scope

Just the icon consts (the truly-identical, single-line strings — zero indentation risk). The env-field / worker-checkbox helpers (which live in the wizard + detail views and differ by indentation/class) follow as separate golden-master-verified PRs, ahead of the guw CSP work.

Part of bead CashPilot-cyc.

…cyc)

renderServiceRow duplicated the restart/stop/logs SVGs verbatim between the
single-instance row and each per-node sub-row (6 copies). Extract them to
ICON_RESTART/ICON_STOP/ICON_LOGS consts. Truly byte-identical: verified by a
DOM golden-master (render the multi-instance row + expanded sub-rows before and
after — the container innerHTML is identical to the byte) plus node --check and
the Playwright harness (row + all action buttons render, 0 console/page errors).

First safe step of the cyc builder componentization; the env-field/worker-checkbox
helpers follow (each golden-master verified against the wizard/detail views).
@GeiserX

GeiserX commented Jul 18, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@GeiserX, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 42 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 99072ab2-1bdc-450d-8138-f878000a105b

📥 Commits

Reviewing files that changed from the base of the PR and between f72a68f and 5df58fe.

📒 Files selected for processing (1)
  • app/static/js/app.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/loop-cyc-svg-icons

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@GeiserX
GeiserX merged commit 2a667fc into main Jul 18, 2026
8 checks passed
@GeiserX
GeiserX deleted the fix/loop-cyc-svg-icons branch July 18, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant