Skip to content

Fix "Implicitly marking parameter X as nullable is deprecated" x 2 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
olivertar wants to merge 1 commit into
base: react-17
Choose a base branch
from
Open

Fix "Implicitly marking parameter X as nullable is deprecated" x 2 #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Block/Product/ImageFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ private function getLabel(Product $product, string $imageType): string
* @param array|null $attributes
* @return ImageBlock
*/
public function create(Product $product, string $imageId, array $attributes = null): ImageBlock
public function create(Product $product, string $imageId, ?array $attributes = null): ImageBlock
{
$viewImageConfig = $this->presentationConfig->getViewConfig()->getMediaAttributes(
'Magento_Catalog',
Expand Down
6 changes: 3 additions & 3 deletions Block/Product/View/Gallery.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,15 @@ public function __construct(
\Magento\Framework\Json\EncoderInterface $jsonEncoder,
ImagePreload $imagePreload,
array $data = [],
\Magento\Catalog\Model\Product\Image\UrlBuilder $urlBuilder = null
?\Magento\Catalog\Model\Product\Image\UrlBuilder $urlBuilder = null
) {
$this->imagePreload = $imagePreload;
parent::__construct($context, $arrayUtils, $jsonEncoder, $data, null, [], $urlBuilder);
}

/**
* Preload mobile hero image using HTTP Link header
*
*
* @param string $imageUrl The URL of the image to preload
* @param bool $isBase64 Whether the image is base64 encoded
* @return void
Expand All @@ -49,7 +49,7 @@ public function preloadMobileImage($imageUrl, $isBase64 = false)

/**
* Check if base64 image encoding is enabled
*
*
* @return bool
*/
public function isBase64ImageEnabled()
Expand Down