Keep Windows terminal open on error by default#6667
Merged
Conversation
rom1v
force-pushed
the
pause-if-error-windows
branch
from
93835f5 to
8b0206f
Compare
rom1v
added a commit
that referenced
this pull request
Feb 24, 2026
Refs #6667 comment <#6667 (review)> Suggested-by: anotheruserofgithub
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If scrcpy is launched by double-clicking
scrcpy.exein Windows Explorer, automatically set--pause-on-exit=if-error.Without this, the terminal would close immediately, preventing the user from seeing the error.
Also remove
scrcpy-console.bat, which is now useless.Detecting whether it is launched by double-clicking relies on a heuristic (it is not 100% reliable). Basically it checks how many processes share the console. If there is only one, then it's probably launched by double-clicking from Windows Explorer. In practice, it works:
scrcpy.exeimplicitly sets--pause-on-exit=if-error.batdoes not implicit pause on exit.Like #6662, the goal is to avoid getting a window that disappears without knowing why, which could suggest that a crash occurred (even though there is no crash).