Skip to content

Narrow geocode param types #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

elchukc
Copy link
Contributor

@elchukc elchukc commented May 16, 2025

Currently, if you pass all the fields allowed by the type system to geocoder.geocode(), the API will return warnings that it was not expecting.

Without changing any functionality, this change to the declaration file improves developer experience for TypeScript users by having the typing system more closely match the alternate URL parameters laid out in the docs.

Also updates library version to 1.10.0 in package-lock.json.

@elchukc elchukc force-pushed the narrow-geocode-param-types branch from 88eafa9 to 9820df9 Compare May 21, 2025 00:48
@elchukc elchukc force-pushed the narrow-geocode-param-types branch from 9820df9 to 9c9d36f Compare May 21, 2025 00:49
@MiniCodeMonkey
Copy link
Member

Thanks for contributing with these changes. This has been manually merged in now.

@elchukc elchukc deleted the narrow-geocode-param-types branch May 21, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants