Skip to content

Conversation

@GL-S
Copy link
Collaborator

@GL-S GL-S commented Mar 27, 2025

Proposed changes

LC product in planetary computer notebook updated

Closes issues (optional)

  • Closes Issue #000

Checklist

If this is a notebook, then have you:

  • Checked the structure of the notebook follows our DEA-notebooks template
  • Removed any unused Python packages from Load packages
  • Removed any unused/empty code cells
  • Removed any guidance cells (e.g. General advice)
  • Ensured that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Included relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Tested notebook on the DEA Sandbox
  • Cleared all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • If applicable, update the Notebook currently compatible with line below the notebook title to reflect the environments the notebook is compatible with
  • Check for any spelling mistakes using the DEA Sandbox's built-in spellchecker (double click on markdown cells then right-click on pink highlighted words). For example:

sandbox_spellchecker

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Member

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this cell:

# Load DEA Land Cover data from DEA
ds_landcover = dc.load(product="ga_ls_landcover_class_cyear_3", 
                       x=x, 
                       y=y, 
                       time=time,
                      resolution=(-30, 30)
                      )

# Inspect output
ds_landcover

Setting resolution here is optional, as datacube will default to what is specified in the product definition, e.g. https://github.com/GeoscienceAustralia/dea-config/blob/master/products/land_and_vegetation/landcover/ga_ls_landcover_class_cyear_3.odc-product.yaml#L29-L30

Totally fine to either remove resolution or leave it in here to make it explicit - but something does look wrong with the spacing/formatting in this code block (e.g. resolution is indented differently). Can you please run Edit > Apply Black or Edit > Apply YAPF to format it?

@GL-S
Copy link
Collaborator Author

GL-S commented Mar 27, 2025

Thanks @robbibt! I think I will remove the resolution

@robbibt robbibt self-requested a review March 27, 2025 02:34
Copy link
Member

@robbibt robbibt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo!

@robbibt robbibt merged commit 9dd5d68 into develop Mar 27, 2025
1 check passed
@robbibt robbibt deleted the update-LC-planetary-NB branch March 27, 2025 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants