-
Notifications
You must be signed in to change notification settings - Fork 134
Continental-scale animation notebook #1336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
It looks good, and it runs on the smallest sandbox, so it's good to be approved I think |
|
sorry didn't mean to request review from everyone! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I made a few minor changes - mostly applying automated formatting via YAPF, and some small documentation and code updates. I changed dask chunks to an even 500 x 500 (Damien recently shared a bug that occurs when using non-square chunks), and used the built-in mask_invalid_data func to set nodata pixels to NaN.
Given the run time of the notebook, I've currrently excluded it from the main integration tests - we can easily restore it later.
|
@robbibt @GL-S @jennaguffogg Thanks for the reviews everybody! |
Proposed changes
As part of my ongoing re-familiarisation with DEA, I've ported over the DE Africa notebook that shows how to export a continental-scale animation. The current example uses a time series of Landsat 8-9 geomedians. Probably too slow for merging in its current configuration but its a place to start the conversation.
Closes issues (optional)
Checklist
If this is a notebook, then have you:
Load packagesGeneral advice)jupyterlab_code_formattertool can be used to format code cells to a consistent style: select each code cell, then clickEditand then one of theApply X Formatteroptions (YAPForBlackare recommended).Notebook currently compatible withline below the notebook title to reflect the environments the notebook is compatible with