Fix parser import by python path

docs/changelog.rst

@@ -15,6 +15,10 @@ This version drop support for Ubuntu Bionic 18.04 debian package. Please update
 - Pre-deprecate support of Ubuntu 20.04. Unit tests will continue but end to end tests will be stopped. Update will be available but install script will be discontinued.
 - Deprecate support of Ubuntu 18.04 bionic.
 
+**Bug fixes**
+
+- Fix: Parser loading with import command (#3538)
+
 
 2.113.1    (2025-02-17)
 ----------------------------

geotrek/common/management/commands/import.py

@@ -3,6 +3,7 @@
 
 from django.conf import settings
 from django.core.management.base import BaseCommand, CommandError
+from django.utils.module_loading import import_string
 
 from geotrek.common.parsers import ImportError
 
@@ -23,24 +24,23 @@ def handle(self, *args, **options):
 
         if '.' in options['parser']:
             # Python import syntax
-            module_name, class_name = options['parser'].rsplit('.', 1)
-            module_path = module_name.replace('.', '/') + '.py'
+            try:
+                Parser = import_string(options['parser'])
+            except Exception:
+                raise CommandError("Failed to import parser class '{0}'".format(options['parser']))
         else:
             # just a class name
-            module_path = join(settings.VAR_DIR, 'conf/parsers.py')
-            module_name = 'parsers'
-            class_name = options['parser']
+            try:
+                module_path = join(settings.VAR_DIR, 'conf/parsers.py')
+                module_name = 'parsers'
+                class_name = options['parser']
+                spec = importlib.util.spec_from_file_location(module_name, module_path)
+                module = importlib.util.module_from_spec(spec)
+                spec.loader.exec_module(module)
+                Parser = getattr(module, class_name)
+            except FileNotFoundError:
+                raise CommandError("Failed to import parser file '{0}'".format(module_path))
 
-        spec = importlib.util.spec_from_file_location(module_name, module_path)
-        module = importlib.util.module_from_spec(spec)
-        try:
-            spec.loader.exec_module(module)
-        except FileNotFoundError:
-            raise CommandError("Failed to import parser file '{0}'".format(module_path))
-        try:
-            Parser = getattr(module, class_name)
-        except AttributeError:
-            raise CommandError("Failed to import parser class '{0}'".format(class_name))
         if not Parser.filename and not Parser.url and not options['filename']:
             raise CommandError("File path missing")
 

geotrek/common/tests/test_parsers.py

@@ -89,12 +89,12 @@ def filter_attachments(self, src, val):
 
 class ParserTests(TestCase):
     def test_bad_parser_class(self):
-        with self.assertRaisesRegex(CommandError, "Failed to import parser class 'DoesNotExist'"):
+        with self.assertRaisesRegex(Exception, "Failed to import parser class 'geotrek.common.tests.test_parsers.DoesNotExist'"):
             call_command('import', 'geotrek.common.tests.test_parsers.DoesNotExist', '', verbosity=0)
 
     def test_bad_parser_file(self):
-        with self.assertRaisesRegex(CommandError, "Failed to import parser file 'geotrek/common.py'"):
-            call_command('import', 'geotrek.common.DoesNotExist', '', verbosity=0)
+        with self.assertRaisesRegex(Exception, "module 'parsers' has no attribute 'DoesNotExist'"):
+            call_command('import', 'DoesNotExist', '', verbosity=0)
 
     def test_no_filename_no_url(self):
         with self.assertRaisesRegex(CommandError, "File path missing"):