Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump mapentity and allow WebP attachment pictures #4535

Merged
merged 2 commits into from
Feb 23, 2025
Merged

Bump mapentity and allow WebP attachment pictures #4535

merged 2 commits into from
Feb 23, 2025

Conversation

submarcos
Copy link
Member

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@submarcos submarcos added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Feb 21, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.47%. Comparing base (d488b3c) to head (2016735).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4535   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         270      270           
  Lines       21523    21523           
=======================================
  Hits        21194    21194           
  Misses        329      329

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress Cypress
Copy link

cypress bot commented Feb 21, 2025 •
edited
Loading

Geotrek-admin    Run #11258

Run Properties:  status check passed Passed #11258  •  git commit bcf0bde4c9 ℹ️: Merge 201673506b93deb4a22fee0f658244d66e4e502e into 92a2dbfbe5f8087f6214512d2bbc...
Project Geotrek-admin
Branch Review refs/pull/4535/merge
Run status status check passed Passed #11258
Run duration 01m 59s
Commit git commit bcf0bde4c9 ℹ️: Merge 201673506b93deb4a22fee0f658244d66e4e502e into 92a2dbfbe5f8087f6214512d2bbc...
Committer Jean-Etienne Castagnede
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

@submarcos submarcos marked this pull request as ready for review February 23, 2025 20:25
@submarcos submarcos merged commit b4ad9df into master Feb 23, 2025
26 checks passed
@submarcos submarcos deleted the bump_mapentity branch February 23, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@submarcos