Ingestion optimization (#13)

GetDKAN · Mar 12, 2020 · 7bedbf4 · 7bedbf4
1 parent 7dbf9d4
commit 7bedbf4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/Parser/Csv.php b/src/Parser/Csv.php
@@ -81,6 +81,15 @@ public function getRecord()
         return $record;
     }
 
+    public function getRecords() : array
+    {
+        $records = [];
+        while ($record = $this->getRecord()) {
+            $records[] = $record;
+        }
+        return $records;
+    }
+
     public function reset()
     {
         $this->field = "";

diff --git a/test/FileTest.php b/test/FileTest.php
@@ -10,10 +10,7 @@ public function test()
         $parser->feed(file_get_contents(__DIR__ . "/data/countries.csv"));
         $parser->finish();
 
-        $records = [];
-        while ($record = $parser->getRecord()) {
-            $records[] = $record;
-        }
+        $records = $parser->getRecords();
 
         $this->assertEquals(5, count($records));
     }