fix(components): Fix Autocomplete Single Char Delete Issue#2917
Open
fix(components): Fix Autocomplete Single Char Delete Issue#2917
Conversation
Deploying atlantis with
|
| Latest commit: |
8aecc8b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5a40cefa.atlantis.pages.dev |
| Branch Preview URL: | https://fix-autocomplete-clearing-is.atlantis.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivations
while looking into another issue I noticed that Autocomplete was misbehaving when I deleted characters one by one rather than clearing all with a select-all and delete
Changes
Added
Changed
Deprecated
Removed
Fixed
also cancel the debounced setter so that when we are removing characters, it's both instantaneous and doesn't get stuck in an invalid state where the UI is empty but our debounce sets the filter value to be the last character we had, resulting in a filtered list that doesn't make sense visually
Security
Testing
pretty straightforward. with a debounce, the default is fine, type something - then delete the characters with consecutive backspaces. on master you'll see that the list becomes filtered. on this branch, it should correctly return to the default, unfiltered state.
the test I wrote was failing, so you can try that against master - and then see that it now passes!
Changes can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.