fix(components): Update SegmentedControl visual styling and add hover state#2919
Open
fix(components): Update SegmentedControl visual styling and add hover state#2919
Conversation
… state - Replace grey background with surface/white and use green border for selected indicator - Add hover effect (green tint) to unselected options only - Use border instead of outline on indicator to prevent overlap with adjacent hover backgrounds - Move focus ring to ::after pseudo-element to maintain visibility above hover layers - Update transition timing from base (200ms) to slow (300ms) with ease-out
Deploying atlantis with
|
| Latest commit: |
024cbb4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://34617e2e.atlantis.pages.dev |
| Branch Preview URL: | https://job-150930-update-segmentedc.atlantis.pages.dev |
Contributor
AutumnDaweBaillie
left a comment
AutumnDaweBaillie
left a comment
There was a problem hiding this comment.
Sorry late to get to this today but on the design side this looks good!
The only thing I found is I noticed with the selected item focus state it looks like it's like covering or hiding the green interactive border somehow. Could we find a way to keep that visible green border in there like however the current one still shows a grey border within the focus ring?
Other than that though this looks good! Checked it out locally and the hover and animation between options feels good! 🎉
before/old colors
after/new colors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivations
User feedback indicated the selected state of SegmentedControl was unclear. This PR updates the visual styling to improve selected/unselected distinction and adds a hover state.
Changes
Added
interactive--background--subtle--hovercolor token (light:green-200, dark:green-800)Changed
interactive) instead of the previous neutral border (border--interactive)interactive--background(grey) tosurface(white)bordertokeninteractive, unselected usestext--secondaryborderinstead ofoutlineto prevent overlap with adjacent hover backgrounds::afterpseudo-element to stay above hover layerstiming-base(200ms) totiming-slow(300ms) with ease-out curveDeprecated
Removed
Fixed
Security
Testing
In Atlantis we use Github's built in pull request reviews.