Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context to post/page preview titles #1954

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add context to post/page preview titles #1954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a79d6e6
Add context to page title
MattSayar Jan 11, 2025
1ef82b4
Add context to post titles
MattSayar Jan 11, 2025
1853d51
Update responsive-srcset.js to also exclude .webp
MattSayar Jan 13, 2025
9fd40a4
Merge pull request #1 from MattSayar/MattSayar-webp-support
MattSayar Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/back-end/modules/render-html/contexts/page-preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ class RendererContextPagePreview extends RendererContext {
this.page.featuredImage = this.getPageFeaturedImages(this.page.id, true);
}

this.metaTitle = 'It is an example value for the preview mode';
this.metaTitle = 'Preview: ' + this.title;
this.metaDescription = 'It is an example value for the preview mode';
this.metaRobots = 'It is an example value for the preview mode';
}
Expand Down
2 changes: 1 addition & 1 deletion app/back-end/modules/render-html/contexts/post-preview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ class RendererContextPostPreview extends RendererContext {
this.tags.sort((tagA, tagB) => tagA.name.localeCompare(tagB.name));
}

this.metaTitle = 'It is an example value for the preview mode';
this.metaTitle = 'Preview: ' + this.title;
this.metaDescription = 'It is an example value for the preview mode';
this.metaRobots = 'It is an example value for the preview mode';
this.post.tags = this.tags;
Expand Down
4 changes: 2 additions & 2 deletions app/back-end/modules/render-html/handlebars/helpers/responsive-srcset.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ function returnSrcSetAttribute (url, type, group) {
return output;
}

// skip GIF and SVG images
if (url.slice(-4) === '.gif' || url.slice(-4) === '.svg') {
// skip GIF, SVG, WEBP images
if (url.slice(-4) === '.gif' || url.slice(-4) === '.svg' || url.slice(-5) === '.webp') {
return output;
}

Expand Down