Skip to content

Restore the previously deleted ChannelListViewModel constructor. #5725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 15, 2025
Merged

Restore the previously deleted ChannelListViewModel constructor. #5725

merged 3 commits into from
Apr 15, 2025

Conversation

VelikovPetar
Copy link
Contributor

🎯 Goal

  • Restores the ChannelListViewModel constructor which accepts globalState: GlobalState

🛠 Implementation details

  • Restores the ChannelListViewModel constructor which accepts globalState: GlobalState (and marks it as deprecated)
  • The new constructor calls the new non-deprecated constructor and passes the globalState as globalState = MutableStateFlow(globalState)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 14, 2025 •
edited
Loading

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 3.16 MB 3.16 MB 0.00 MB 🟢
stream-chat-android-offline 3.38 MB 3.38 MB 0.00 MB 🟢
stream-chat-android-ui-components 7.89 MB 7.89 MB 0.00 MB 🟢
stream-chat-android-compose 9.90 MB 9.90 MB 0.00 MB 🟢

@VelikovPetar VelikovPetar marked this pull request as ready for review April 14, 2025 12:17
@VelikovPetar VelikovPetar requested a review from a team as a code owner April 14, 2025 12:17
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@JcMinarro JcMinarro merged commit 330bc11 into develop Apr 15, 2025
13 of 14 checks passed
@JcMinarro JcMinarro deleted the feature/restore-channel-list-vm-constructor branch April 15, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JcMinarro JcMinarro JcMinarro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VelikovPetar @JcMinarro