Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fix screen sharing on web.
Fixes FLU-124
🛠 Implementation details
When starting to share your screen on web the
_setTrackEnabled
is called, but the deviceId is alwaysnull
for the requirements. ThereforecompareScreenShareMode
is always true, even though we should create a new track.The callback is then set to the wrong track, the old one: https://github.com/GetStream/stream-video-flutter/blob/main/packages/stream_video/lib/src/call/call.dart#L2428-L2430
Debugging showed that on the actual track the onEnded callback was
null
: https://github.com/flutter-webrtc/dart-webrtc/blob/main/lib/src/media_stream_track_impl.dart#L16🧪 Testing
Test by running on web and start screen sharing only tabs and stop them using the browser tools.
☑️Contributor Checklist
General
☑️Reviewer Checklist