Feature/improve dogfooding settings menu #960
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fixes FLU-104
Improve the options menu in the dogfooding app and make it more aligned to other platforms.
🛠 Implementation details
It sets the max width, so it becomes better usable on large screens.
It moves some menu items around and hides some on release builds. Those that are hidden on release are shown as 'dev options'
It adds a quick option for background filters on supported platforms.
To show the currently selected filter I added an
appliedVideoEffects
field in theStreamVideoEffectsManager
. We might want to add a method channel so you can also fetch this from the native side instead of depending on the state in the manager. That's also why it's nullable, because before you set a filter we are not sure if a filter is set.🎨 UI Changes
Desktop before / after:
Mobile with and without dev options:
🧪 Testing
On desktop you can easily test the sizing, but background filters are not supported, those should be tested on mobile.
☑️Contributor Checklist
General
☑️Reviewer Checklist