Skip to content

Feature/improve dogfooding settings menu #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2025

Conversation

renefloor
Copy link
Contributor

@renefloor renefloor commented May 16, 2025

🎯 Goal

Fixes FLU-104

Improve the options menu in the dogfooding app and make it more aligned to other platforms.

🛠 Implementation details

It sets the max width, so it becomes better usable on large screens.
It moves some menu items around and hides some on release builds. Those that are hidden on release are shown as 'dev options'
It adds a quick option for background filters on supported platforms.

To show the currently selected filter I added an appliedVideoEffects field in the StreamVideoEffectsManager. We might want to add a method channel so you can also fetch this from the native side instead of depending on the state in the manager. That's also why it's nullable, because before you set a filter we are not sure if a filter is set.

🎨 UI Changes

Desktop before / after:

Before After
Screenshot 2025-05-16 at 13 52 16 Screenshot 2025-05-16 at 13 49 39

Mobile with and without dev options:

With Without
Screenshot_20250516-134633 Screenshot_20250516-134647

🧪 Testing

On desktop you can easily test the sizing, but background filters are not supported, those should be tested on mobile.

☑️Contributor Checklist

General

  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#flutter-team) (required)
  • PR is linked to the GitHub issue it resolves

☑️Reviewer Checklist

  • Sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • All code we touched has new or updated Documentation

@renefloor renefloor requested a review from a team as a code owner May 16, 2025 11:58
@renefloor renefloor merged commit 4bcad58 into main May 20, 2025
8 checks passed
@renefloor renefloor deleted the feature/improve-dogfooding-settings-menu branch May 20, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants