-
Notifications
You must be signed in to change notification settings - Fork 30
[CI] Support Xcode 26 #955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
testableapple
wants to merge
2
commits into
develop
Choose a base branch
from
ci/xcode26
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,32 +41,27 @@ jobs: | |
| strategy: | ||
| matrix: | ||
| include: | ||
| - ios: 18.5 | ||
| xcode: 16.3 | ||
| os: macos-15 | ||
| # - ios: "26.0" TODO: IOS-1181 | ||
| # device: "iPhone 17 Pro" | ||
| # setup_runtime: false | ||
| - ios: "18.5" | ||
| device: "iPhone 16 Pro" | ||
| setup_runtime: false | ||
| - ios: 17.5 | ||
| xcode: 15.4 | ||
| os: macos-14 | ||
| - ios: "17.5" | ||
| device: "iPhone 15 Pro" | ||
| setup_runtime: false | ||
| - ios: 16.4 | ||
| xcode: 15.3 | ||
| os: macos-14 | ||
| device: "iPhone 14" | ||
| setup_runtime: true | ||
| - ios: 15.5 | ||
| xcode: 15.4 | ||
| os: macos-14 | ||
| - ios: "16.4" | ||
| device: "iPhone 14 Pro" | ||
| setup_runtime: true | ||
| - ios: "15.5" | ||
| device: "iPhone 13 Pro" | ||
| setup_runtime: true | ||
| fail-fast: false | ||
| runs-on: ${{ matrix.os }} | ||
| runs-on: macos-15 | ||
| env: | ||
| GITHUB_EVENT: ${{ toJson(github.event) }} | ||
| ALLURE_TOKEN: ${{ secrets.ALLURE_TOKEN }} | ||
| XCODE_VERSION: ${{ matrix.xcode }} | ||
| XCODE_VERSION: "26.0.1" | ||
| IOS_SIMULATOR_DEVICE: "${{ matrix.device }} (${{ matrix.ios }})" # For the Allure report | ||
| steps: | ||
| - uses: actions/[email protected] | ||
|
|
@@ -124,30 +119,25 @@ jobs: | |
| strategy: | ||
| matrix: | ||
| include: | ||
| - ios: 18.5 | ||
| xcode: 16.3 | ||
| os: macos-15 | ||
| - ios: "26.0" | ||
| device: "iPhone 17 Pro" | ||
| setup_runtime: false | ||
| - ios: "18.5" | ||
| device: "iPhone 16 Pro" | ||
| setup_runtime: false | ||
| - ios: 17.5 | ||
| xcode: 15.4 | ||
| os: macos-14 | ||
| - ios: "17.5" | ||
| device: "iPhone 15 Pro" | ||
| setup_runtime: false | ||
| - ios: 16.4 | ||
| xcode: 15.3 | ||
| os: macos-14 | ||
| setup_runtime: true | ||
| - ios: "16.4" | ||
| device: "iPhone 14 Pro" | ||
| setup_runtime: true | ||
| - ios: 15.5 | ||
| xcode: 15.3 | ||
| os: macos-14 | ||
| - ios: "15.5" | ||
| device: "iPhone 13 Pro" | ||
| setup_runtime: true | ||
| fail-fast: false | ||
| runs-on: ${{ matrix.os }} | ||
| runs-on: macos-15 | ||
| env: | ||
| XCODE_VERSION: ${{ matrix.xcode }} | ||
| XCODE_VERSION: "26.0.1" | ||
| steps: | ||
| - uses: actions/[email protected] | ||
| - uses: ./.github/actions/bootstrap | ||
|
|
@@ -196,17 +186,18 @@ jobs: | |
| run: bundle exec fastlane build_docs_test | ||
|
|
||
| build-old-xcode: | ||
| name: Build SDKs (Xcode 15) | ||
| name: Build SDKs (Old Xcode) | ||
| runs-on: macos-14 | ||
| if: ${{ github.event_name != 'push' && github.event.inputs.snapshots != 'true' }} | ||
| env: | ||
| XCODE_VERSION: "15.4" | ||
| XCODE_VERSION: "16.1" | ||
| steps: | ||
| - name: Connect Bot | ||
| uses: webfactory/[email protected] | ||
| with: | ||
| ssh-private-key: ${{ secrets.BOT_SSH_PRIVATE_KEY }} | ||
| - uses: actions/[email protected] | ||
| - uses: ./.github/actions/xcode-cache | ||
| - uses: ./.github/actions/ruby-cache | ||
| - name: List Xcode versions | ||
| run: mdfind "kMDItemCFBundleIdentifier = 'com.apple.dt.Xcode'" | ||
|
|
@@ -229,7 +220,7 @@ jobs: | |
| name: Automated Code Review | ||
| runs-on: macos-14 | ||
| env: | ||
| XCODE_VERSION: "15.4" | ||
| XCODE_VERSION: "16.1" | ||
| steps: | ||
| - uses: actions/[email protected] | ||
| - uses: ./.github/actions/bootstrap | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,7 +25,7 @@ concurrency: | |
|
|
||
| env: | ||
| HOMEBREW_NO_INSTALL_CLEANUP: 1 # Disable cleanup for homebrew, we don't need it on CI | ||
| IOS_SIMULATOR_DEVICE: "iPhone 16 Pro (18.5)" | ||
| IOS_SIMULATOR_DEVICE: "iPhone 17 Pro (26.0)" | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GITHUB_PR_NUM: ${{ github.event.pull_request.number }} | ||
|
|
||
|
|
@@ -83,6 +83,8 @@ jobs: | |
| if: ${{ github.event.inputs.record_snapshots_uikit != 'true' || github.event.inputs.record_snapshots_swiftui == 'true' }} | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.CI_BOT_GITHUB_TOKEN }} # to open a PR | ||
| IOS_SIMULATOR_DEVICE: "iPhone 16 Pro (18.5)" # TODO: IOS-1181 | ||
| XCODE_VERSION: "16.4" # TODO: IOS-1181 | ||
| steps: | ||
| - uses: actions/[email protected] | ||
| - uses: ./.github/actions/bootstrap | ||
|
|
@@ -133,7 +135,7 @@ jobs: | |
| name: Automated Code Review | ||
| runs-on: macos-14 | ||
| env: | ||
| XCODE_VERSION: "15.4" | ||
| XCODE_VERSION: "16.1" | ||
| if: ${{ github.event.inputs.record_snapshots_swiftui != 'true' && github.event.inputs.record_snapshots_uikit != 'true' }} | ||
| steps: | ||
| - uses: actions/[email protected] | ||
|
|
@@ -147,29 +149,30 @@ jobs: | |
| - run: bundle exec fastlane pod_lint | ||
| if: startsWith(github.event.pull_request.head.ref, 'release/') | ||
|
|
||
| build-xcode15: | ||
| name: Build SDKs (Xcode 15) | ||
| build-old-xcode: | ||
| name: Build SDKs (Old Xcode) | ||
| runs-on: macos-14 | ||
| needs: test-llc-debug | ||
| if: ${{ github.event.inputs.record_snapshots_swiftui != 'true' && github.event.inputs.record_snapshots_uikit != 'true' }} | ||
| env: | ||
| XCODE_VERSION: "15.4" | ||
| XCODE_VERSION: "16.1" | ||
| steps: | ||
| - name: Connect Bot | ||
| uses: webfactory/[email protected] | ||
| with: | ||
| ssh-private-key: ${{ secrets.BOT_SSH_PRIVATE_KEY }} | ||
| - uses: actions/[email protected] | ||
| - uses: ./.github/actions/xcode-cache | ||
| - uses: ./.github/actions/ruby-cache | ||
| - name: List Xcode versions | ||
| run: mdfind "kMDItemCFBundleIdentifier = 'com.apple.dt.Xcode'" | ||
| - name: Build LLC | ||
| run: bundle exec fastlane test device:"iPhone 15" build_for_testing:true | ||
| run: bundle exec fastlane test device:"iPhone 16" build_for_testing:true | ||
| timeout-minutes: 25 | ||
| - name: Build SwiftUI | ||
| run: bundle exec fastlane test_swiftui device:"iPhone 15" build_for_testing:true | ||
| run: bundle exec fastlane test_swiftui device:"iPhone 16" build_for_testing:true | ||
| - name: Build UIKit | ||
| run: bundle exec fastlane test_uikit device:"iPhone 15" build_for_testing:true | ||
| run: bundle exec fastlane test_uikit device:"iPhone 16" build_for_testing:true | ||
| timeout-minutes: 25 | ||
| - name: Build XCFrameworks | ||
| run: bundle exec fastlane build_xcframeworks | ||
|
|
@@ -248,6 +251,8 @@ jobs: | |
| env: | ||
| LAUNCH_ID: ${{ needs.allure_testops_launch.outputs.launch_id }} | ||
| ALLURE_TOKEN: ${{ secrets.ALLURE_TOKEN }} | ||
| IOS_SIMULATOR_DEVICE: "iPhone 16 Pro (18.5)" # TODO: IOS-1181 | ||
| XCODE_VERSION: "16.4" # TODO: IOS-1181 | ||
| strategy: | ||
| matrix: | ||
| batch: [0] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-46 Bytes
(100%)
...lViewController_Tests/test_callViewController_outgoingSnapshot.default-dark.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-173 Bytes
(100%)
...ViewController_Tests/test_callViewController_outgoingSnapshot.default-light.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,2 @@ | ||
| # For more information about this configuration visit | ||
| # https://docs.fastlane.tools/actions/scan/#scanfile | ||
|
|
||
| # In general, you can use the options available | ||
| # fastlane scan --help | ||
|
|
||
| devices(["iPhone 15 Pro"]) | ||
|
|
||
| # Needed for Sonar | ||
| code_coverage(true) | ||
|
|
||
| configuration("Test") | ||
|
|
||
| configuration('Test') | ||
| result_bundle(true) | ||
|
|
||
| skip_slack(true) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thinking if we should keep it unchanged since most of the customers use the default setting. This just makes the report nicer.