Skip to content

fix(iOS): remove private api use from broadcast picker - #80

Merged
Brazol merged 1 commit into
mainfrom
fix/private-api-use-removed
Jul 28, 2026
Merged

fix(iOS): remove private api use from broadcast picker#80
Brazol merged 1 commit into
mainfrom
fix/private-api-use-removed

Conversation

@Brazol

@Brazol Brazol commented Jul 28, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

  • Bug Fixes

    • Fixed iOS screen sharing so the broadcast picker opens using supported system interactions.
    • Added handling and logging for cases where the broadcast picker control cannot be located.
  • Documentation

    • Added an upcoming release note describing the iOS screen-sharing fix.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b39ca2b2-9846-4a21-8178-e3d8e8361826

📥 Commits

Reviewing files that changed from the base of the PR and between d7098ba and f89e63d.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • ios/stream_webrtc_flutter/Sources/stream_webrtc_flutter/FlutterRTCDesktopCapturer.m

📝 Walkthrough

Walkthrough

Changes

iOS broadcast picker

Layer / File(s) Summary
Public broadcast picker trigger
ios/stream_webrtc_flutter/Sources/stream_webrtc_flutter/FlutterRTCDesktopCapturer.m, CHANGELOG.md
Screen-share activation replaces the private buttonPressed: selector with a public UIButton touch-up event, logs when no button is found, and records the change in the changelog. Nearby video-track construction is reformatted without behavior changes.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: removing private API use from the iOS broadcast picker.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/private-api-use-removed

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Brazol
Brazol merged commit 283779b into main Jul 28, 2026
12 checks passed
@Brazol
Brazol deleted the fix/private-api-use-removed branch July 28, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants