Add prev/next navigation support for text, images, video. Fix undo/redo toolbox issue.#489
Add prev/next navigation support for text, images, video. Fix undo/redo toolbox issue.#489cubiclesoft wants to merge 5 commits intoGetmeUK:masterfrom
Conversation
|
@cubiclesoft Thanks for this (and the PR on ContentEdit) I'll be merging them in this weekend (awesome work) 👍 Can I check with this PR, if I merge in this code with the touch support is there anything I should be aware of around touch support, e.g does touch support change the functionality of the editor beyond simple adding the ability to use touch events? |
|
To get touch support working for toolbox, I reverted back to https://cubiclesoft.com/Unrelated/ContentToolsDragTest/sandbox/ Looking back at the commit, the only obvious significant change that I see is the addition of |
|
Just thought of one minor bug: When switching regions, the 'next-region' and 'previous-region' triggers will still jump to 'content' it finds instead of the navigable. That is, |
|
Latest commit fixes next/previous region navigation. |
|
Thanks for the update 👍 |
Unfortunately, due to a messed up master (see my other open pull request), this branch also includes the earlier code for fixing touch support for CT toolbox. (I'll do better branch-merging in the future.)
The changes here add keyboard navigation support for images and video elements to other elements. I also fixed a bug that I ran into where undo and redo via keyboard were not functioning as expected (case statements in Javascript don't accept expressions).
Partially fixes some of the issues in #487.
Related pull request: GetmeUK/ContentEdit#25